impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4574: Do not treat UUID() like a constant expr.
Date Fri, 02 Dec 2016 21:13:28 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4574: Do not treat UUID() like a constant expr.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5324/1/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java
File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java:

Line 246:     if (fnName.equalsIgnoreCase("rand") || fnName.equalsIgnoreCase("random")
> Agree that we need to deal with such UDFs in a more principled way.
That doesn't avoid caching of constant expression values in the backend though, or any other
code that trusts the output of isConstant() though (even before constant folding we incorrectly
could assume that these expressions were constant for partition pruning, etc).

It doesn't seem that exotic that a customer might implement a UDF equivalent to UUID() or
similar.

I'm happy to do the work if we want to do it as a follow-up patch/bug.


-- 
To view, visit http://gerrit.cloudera.org:8080/5324
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2499f5f6ecdcb098623202c8e6dc2d02727194a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message