impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load
Date Fri, 02 Dec 2016 00:34:24 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5144/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 1277:       } catch (NoSuchObjectException e) {
> I don't quite understand how this is different from what the patch was orig
I don't see the purpose of this patch that way. In my mind the purpose is to allow dropping
tables even if they failed to load (that was not possible before). The fact that you get a
TableLoadingException in the "externally deleted from Kudu" case is specific to Kudu, and
an artifact of the inconsistency between HMS and Kudu with respect to that one table. The
Kudu specific fix here is the ability to clean up the inconsistent metadata in the HMS, but
that is not necessary for the Hive-table only case.

The Hive table case is different. There is only one source of truth and that's the HMS. The
semantics of DROP without IF EXISTS is that errors are shown to the user.

I didn't follow the part about the usability regression, maybe you can help me understand
in person.


-- 
To view, visit http://gerrit.cloudera.org:8080/5144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b41fc3c0e95508ab67f1d420b033b02ec75a5da
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message