impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model
Date Thu, 01 Dec 2016 23:56:53 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5162/7/tests/comparison/model_translator.py
File tests/comparison/model_translator.py:

Line 727:   def _write_concat(self, func):
> Wasn't this in a separate review?
Yes, and it was submitted after your +2 (thanks!), and then this was rebased on top of it
in patch set 6.


http://gerrit.cloudera.org:8080/#/c/5162/7/tests/comparison/query.py
File tests/comparison/query.py:

PS7, Line 56: self.with_clause.table_exprs
> After thinking about this some more, we might need to make a copy here with
I talked to Taras separately and the concern here is, does the += modify the list we get back
from the property reader? It seems like we shouldn't, since that defeats the purpose of a
property. I'll look into it.

Also, I'll change the += to extend()

Last, this needs to be a TableExprList, not [].


-- 
To view, visit http://gerrit.cloudera.org:8080/5162
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e24da78c49e908449b35f0a6276ebe4236ddba
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message