impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp
Date Thu, 01 Dec 2016 23:54:40 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp
......................................................................


Patch Set 6:

> (2 comments)
 > 
 > Dan: so there's actually a special case in exprs/scalar-fn-call.cc
 > that disables codegen for functions with "AddSub" in the name. This
 > is a bit of a hack and could be cleaned up in various way.
 > 
 > I also experimented with disabling that hack and it looks like
 > exception handling in IR actually works to some extent, so maybe
 > it's worth reevaluating later. I wonder if we should just move some
 > of those functions to timestamp-functions.cc, since I don't think
 > we're using the IR.

Yes, I was thinking we'd just move those functions to timestamp-function.cc.  But if it's
not a real bug, no need to do it right now.

-- 
To view, visit http://gerrit.cloudera.org:8080/5251
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc427b06ac33ec874a05cb98d01c00e970d3dde6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message