impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4498: crash in to utc timestamp/from utc timestamp
Date Thu, 01 Dec 2016 23:09:16 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4498: crash in to_utc_timestamp/from_utc_timestamp

Patch Set 4:


Dan: so there's actually a special case in exprs/ that disables codegen for
functions with "AddSub" in the name. This is a bit of a hack and could be cleaned up in various

I also experimented with disabling that hack and it looks like exception handling in IR actually
works to some extent, so maybe it's worth reevaluating later. I wonder if we should just move
some of those functions to, since I don't think we're using the IR.
File be/src/exprs/

Line 3616:                   "as timestamp), interval 13 months) as string)",
> odd indentation.
I don't think it's configurable - it wants to line up the multi-line strings and there's no
option I could find to disable that.

Manually reverted it.
File be/src/exprs/

Line 54: void ThrowExceptionIfTimestampOutOfRange(const boost::gregorian::date& date)
> remove Exception, it's implied in Throw.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc427b06ac33ec874a05cb98d01c00e970d3dde6
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message