impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins
Date Thu, 01 Dec 2016 21:15:43 GMT
Hello Michael Ho, Dan Hecht,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#2).

Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins

IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins

Fix a test bug where we need to skip nested types tests for the old aggs
and joins.

Fix a product bug where *eos is not initialised by the MT scan node.
This causes incorrect results when the calling ExecNode does not
initialise the eos variable, e.g. the sort node and the old agg and join

Added a test that reproduces the incorrect results with the sort node
when run under ASAN

Tested the mt_dop tests locally with old aggs and joins to ensure they

Change-Id: I48c50c8aa0c23710eb099fba252bc3c0cb74b313
M be/src/exec/
A testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-nested.test
M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet.test
M testdata/workloads/functional-query/queries/QueryTest/mt-dop.test
M tests/query_test/
5 files changed, 54 insertions(+), 33 deletions(-)

  git pull ssh:// refs/changes/02/5302/2
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I48c50c8aa0c23710eb099fba252bc3c0cb74b313
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <>

View raw message