impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4564,IMPALA-4565: mt dop fixes for old aggs and joins
Date Thu, 01 Dec 2016 18:45:40 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4564,IMPALA-4565: mt_dop fixes for old aggs and joins
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5302/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet.test:

Line 9: # IMPALA-4565: incorrect results because mt scan node does not set eos
move this into mt-dop.test since it's not specific to Parquet and getting coverage over all
file formats seems not bad


Line 11: set disable_outermost_topn=true;
I'm a little wary of having this test coverage depend on this 'exotic' query option. Maybe
the same can be achieved by using an order by without limit on alltypestiny, but setting the
batch size to 1?


-- 
To view, visit http://gerrit.cloudera.org:8080/5302
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48c50c8aa0c23710eb099fba252bc3c0cb74b313
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message