impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load
Date Thu, 01 Dec 2016 02:41:29 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4357: Fix DROP TABLE to pass analysis if the table fails to load
......................................................................


Patch Set 2:

(1 comment)

This is a great fix! Pretty minimal. I think there is an existing JIRA to fix this behavior
for DROP of tables that fail to load. Let me know if you cannot find it, I can help you dig
it up.

http://gerrit.cloudera.org:8080/#/c/5144/2/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java
File fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java:

Line 100:       // We should still try to DROP tables that failed to load, so that tables
that are
We need to add an access event for auditing in this case, because we are indeed going to access
(drop) the table. We should also add a test for this case. You can take a look at AnalyzerTest.TestUnsupportedTypes()
for suitable test tables.

We should also add a test in AnalyzeDDL that shows such tables pass analysis.


-- 
To view, visit http://gerrit.cloudera.org:8080/5144
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b41fc3c0e95508ab67f1d420b033b02ec75a5da
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message