Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E23D6200BB1 for ; Thu, 3 Nov 2016 22:09:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E0D73160AFF; Thu, 3 Nov 2016 21:09:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 35A69160AE5 for ; Thu, 3 Nov 2016 22:09:57 +0100 (CET) Received: (qmail 91564 invoked by uid 500); 3 Nov 2016 21:09:56 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 91549 invoked by uid 99); 3 Nov 2016 21:09:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 21:09:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C72C3C0957 for ; Thu, 3 Nov 2016 21:09:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id D6GYYsZv1A8Y for ; Thu, 3 Nov 2016 21:09:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E2A415FB12 for ; Thu, 3 Nov 2016 21:09:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uA3L9rep002839; Thu, 3 Nov 2016 21:09:53 GMT Date: Thu, 3 Nov 2016 21:09:53 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4391=3A_fix_dropped_statuses_in_scanners=0A?= X-Gerrit-Change-Id: I7c47f8b29a20dc74ad9e9e1c58b3d7ed95de4d35 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6e4bd0d3a795ee854d8529ffef13c3addc3dd820 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 03 Nov 2016 21:09:58 -0000 Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4938 Change subject: IMPALA-4391: fix dropped statuses in scanners ...................................................................... IMPALA-4391: fix dropped statuses in scanners As far as I'm aware we haven't seen any failures related to these in practice, but fixing them as a preventative measure. Testing: I was unable to reproduce this easily by adding a failpoint. I suspect that stress testing of the affected file formats would have eventually found this, because of the similarity to IMPALA-3962. Change-Id: I7c47f8b29a20dc74ad9e9e1c58b3d7ed95de4d35 --- M be/src/exec/base-sequence-scanner.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-rcfile-scanner.cc M be/src/exec/hdfs-rcfile-scanner.h M be/src/exec/hdfs-scanner.h M be/src/exec/hdfs-sequence-scanner.cc M be/src/exec/hdfs-text-scanner.cc 7 files changed, 18 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/4938/1 -- To view, visit http://gerrit.cloudera.org:8080/4938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7c47f8b29a20dc74ad9e9e1c58b3d7ed95de4d35 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong