Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201611302335.uAUNZbP2003171@ip-10-146-233-104.ec2.internal>
Date: Wed, 30 Nov 2016 23:35:37 +0000
From: "Dimitris Tsirogiannis (Code Review)" <gerrit@cloudera.org>
To: Bharath Vissapragada <bharathv@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Mostafa Mokhtar <mmokhtar@cloudera.com>,
        Alex Behm <alex.behm@cloudera.com>
Reply-To: dtsirogiannis@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4172/IMPALA-3653=3A_Improvements_to_block_metadata_loading=0A?=
In-Reply-To: <gerrit.1479520808000.Ie127658172e6e70dae441374530674a4ac9d5d26@gerrit.cloudera.org>
References: <gerrit.1479520808000.Ie127658172e6e70dae441374530674a4ac9d5d26@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 30 Nov 2016 23:36:32 -0000

Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
......................................................................


Patch Set 15: Code-Review+2

(2 comments)

Nice!

http://gerrit.cloudera.org:8080/#/c/5148/15/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

PS15, Line 794: for (Path location: locations) {
              :       loadBlockMetadata(fs, location, partsByPath);
              :     }
nit: single line?


PS15, Line 1034: while reusing existing file descriptors to avoid loading metadata for files
               :    * that haven't changed.
This is no longer valid. Remove?


-- 
To view, visit http://gerrit.cloudera.org:8080/5148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie127658172e6e70dae441374530674a4ac9d5d26
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes