Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D2559200BD0 for ; Wed, 30 Nov 2016 20:53:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D0F98160B19; Wed, 30 Nov 2016 19:53:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9BA05160B06 for ; Wed, 30 Nov 2016 20:53:23 +0100 (CET) Received: (qmail 42707 invoked by uid 500); 30 Nov 2016 19:53:22 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 42694 invoked by uid 99); 30 Nov 2016 19:53:22 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 19:53:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 295821800EC for ; Wed, 30 Nov 2016 19:53:22 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DHwzIm3fxaEC for ; Wed, 30 Nov 2016 19:53:20 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8BDE15FDB5 for ; Wed, 30 Nov 2016 19:53:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAUJrCtX020371; Wed, 30 Nov 2016 19:53:12 GMT Message-Id: <201611301953.uAUJrCtX020371@ip-10-146-233-104.ec2.internal> Date: Wed, 30 Nov 2016 19:53:12 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Amos Bird , Dan Hecht Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Fix_undefined_cals_to___builtin_ctz=2E=0A?= X-Gerrit-Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe X-Gerrit-ChangeURL: X-Gerrit-Commit: 1a1a532877d484b52f32c23c4b3781e091063b72 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 30 Nov 2016 19:53:25 -0000 Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5004 to look at the new patch set (#3). Change subject: Fix undefined cals to __builtin_ctz. ...................................................................... Fix undefined cals to __builtin_ctz. GCC's __builtin_ctz[l[l]] functions return undefined results when the argument is 0. This patch handles that 0 case, which could otherwise produce results that depend on the architecture. Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe --- M be/src/exprs/aggregate-functions-ir.cc M be/src/udf_samples/hyperloglog-uda.cc M be/src/util/bit-util.h 3 files changed, 43 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/5004/3 -- To view, visit http://gerrit.cloudera.org:8080/5004 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8460bc3f7e510ce07b8673387c9440accc432abe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Amos Bird Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong