Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3C957200BD0 for ; Wed, 30 Nov 2016 15:16:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B2F8160B13; Wed, 30 Nov 2016 14:16:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 832F7160B08 for ; Wed, 30 Nov 2016 15:16:30 +0100 (CET) Received: (qmail 96190 invoked by uid 500); 30 Nov 2016 14:16:29 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 96171 invoked by uid 99); 30 Nov 2016 14:16:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 14:16:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1D8E0C73DA for ; Wed, 30 Nov 2016 14:16:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Rzk_wPZ87MdI for ; Wed, 30 Nov 2016 14:16:27 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 174F95F58F for ; Wed, 30 Nov 2016 14:16:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAUEGOLo010111; Wed, 30 Nov 2016 14:16:24 GMT Message-Id: <201611301416.uAUEGOLo010111@ip-10-146-233-104.ec2.internal> Date: Wed, 30 Nov 2016 14:16:23 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho , Sailesh Mukil Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4543=3A_Properly_escape_ignored_tests_subdirectories=2E=0A?= X-Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6db04f43b35751bca9e4301a4f86e77121e60625 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 30 Nov 2016 14:16:31 -0000 Jim Apple has uploaded a new patch set (#2). Change subject: IMPALA-4543: Properly escape ignored tests subdirectories. ...................................................................... IMPALA-4543: Properly escape ignored tests subdirectories. In the shell, double-quoted strings are not very close to "raw" strings; double quotes end the string, but parameter expansion is also performed forstrings like "${FOO}". To pass strings from Python to the shell, I have replaced double quotes with single quotes and escaped the single quote characters in the strings. While I am here, add better logging in TestExecutor.run_tests to make errors like this easier to diagnose. Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7 --- M tests/run-tests.py 1 file changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/42/5242/2 -- To view, visit http://gerrit.cloudera.org:8080/5242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I006eb559ec5f5b5b0379997fab945116dfc7e8d7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Sailesh Mukil