Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201611290020.uAT0KEIr022334@ip-10-146-233-104.ec2.internal>
Date: Tue, 29 Nov 2016 00:20:13 +0000
From: "Marcel Kornacker (Code Review)" <gerrit@cloudera.org>
To: Jim Apple <jbapple-impala@apache.org>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Henry Robinson <henry@cloudera.com>
Reply-To: marcel@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Avoid_std=3A=3Afunction_when_possible=2E=0A?=
In-Reply-To: <gerrit.1480147186000.If9dc034c2e094ea7f87f78d8d9101a71d8d2e295@gerrit.cloudera.org>
References: <gerrit.1480147186000.If9dc034c2e094ea7f87f78d8d9101a71d8d2e295@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Tue, 29 Nov 2016 00:20:22 -0000

Marcel Kornacker has posted comments on this change.

Change subject: Avoid std::function when possible.
......................................................................


Patch Set 1:

> > I do not find it more readable, but I find it to be readable
 > enough; I think the readability delta is a good price to pay to
 > avoid boxing up a lambda.
 > 
 > Could you be more specific about the drawbacks? We've spoken about
 > heap allocation; personally I don't think that's an issue because
 > it's not unusual, but perhaps that's a dealbreaker for you.
 > Otherwise I know you consider it 'overkill', but I don't yet know
 > why. Perhaps there's something about this class in particular that
 > makes it a bad choice for std::function?

Heap allocation is actually an issue, because it doesn't go with how we (eventually) want to do memory management and reservations. I understand that we do this elsewhere, by virtue of using STL, but we shouldn't add to it.

Throwing in the c'tor is also not okay.

-- 
To view, visit http://gerrit.cloudera.org:8080/5230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9dc034c2e094ea7f87f78d8d9101a71d8d2e295
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: No