Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 137F6200BCB for ; Thu, 24 Nov 2016 09:03:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 11961160B1E; Thu, 24 Nov 2016 08:03:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5CE48160B11 for ; Thu, 24 Nov 2016 09:03:34 +0100 (CET) Received: (qmail 35550 invoked by uid 500); 24 Nov 2016 08:03:33 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 35531 invoked by uid 99); 24 Nov 2016 08:03:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Nov 2016 08:03:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EFB34C033A for ; Thu, 24 Nov 2016 08:03:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MGtUXLuj4Caq for ; Thu, 24 Nov 2016 08:03:30 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 147C75F307 for ; Thu, 24 Nov 2016 08:03:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAO83TJV030950; Thu, 24 Nov 2016 08:03:29 GMT Message-Id: <201611240803.uAO83TJV030950@ip-10-146-233-104.ec2.internal> Date: Thu, 24 Nov 2016 08:03:29 +0000 From: "Internal Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4529=3A_speed_up_parsing_of_identifiers=0A?= X-Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd X-Gerrit-ChangeURL: X-Gerrit-Commit: 90ebecdd407708e28ff4ff234ee059dd2d3b190e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 24 Nov 2016 08:03:35 -0000 Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4529: speed up parsing of identifiers ...................................................................... IMPALA-4529: speed up parsing of identifiers Instead of using substring(), parseInt() and a try/catch, directly check the character. Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd Reviewed-on: http://gerrit.cloudera.org:8080/5210 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebef43a6a2f7923ca0e9c158d83f5c06f26da0cd Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Internal Jenkins