Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3F78F200BD5 for ; Thu, 24 Nov 2016 00:50:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3DC37160B0A; Wed, 23 Nov 2016 23:50:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 83E58160AFD for ; Thu, 24 Nov 2016 00:50:33 +0100 (CET) Received: (qmail 11921 invoked by uid 500); 23 Nov 2016 23:50:32 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 11878 invoked by uid 99); 23 Nov 2016 23:50:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2016 23:50:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1177DCEC29 for ; Wed, 23 Nov 2016 23:50:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 6wqtSHjy-QQz for ; Wed, 23 Nov 2016 23:50:30 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id EB0BE5F4A6 for ; Wed, 23 Nov 2016 23:50:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uANNoNex024926; Wed, 23 Nov 2016 23:50:23 GMT Message-Id: <201611232350.uANNoNex024926@ip-10-146-233-104.ec2.internal> Date: Wed, 23 Nov 2016 23:50:23 +0000 From: "Alex Behm (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4525=3A_fix_crash_when_codegen_mem_limit_exceeded=0A?= X-Gerrit-Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505 X-Gerrit-ChangeURL: X-Gerrit-Commit: 31e1e15740c5cc78668ca0beb720d890c77e2e7c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 23 Nov 2016 23:50:34 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5211/2/be/src/service/fe-support.cc File be/src/service/fe-support.cc: PS2, Line 110: THROW_IF_ERROR_RET( : state.CreateCodegen(), env, JniUtil::internal_exc_class(), result_bytes); > Not your change but this may need to the same clean up too. It's almost lik Agree PS2, Line 118: for (int i = 0; i < expr_ctxs.size(); ++i) { : expr_ctxs[i]->Close(&state); : } > I might clean this and the above comment up in the follow-up patch. Agree -- To view, visit http://gerrit.cloudera.org:8080/5211 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes