Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CF275200BC8 for ; Wed, 23 Nov 2016 19:15:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CDCBA160AFD; Wed, 23 Nov 2016 18:15:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 257E4160AEC for ; Wed, 23 Nov 2016 19:15:17 +0100 (CET) Received: (qmail 69400 invoked by uid 500); 23 Nov 2016 18:15:12 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 68837 invoked by uid 99); 23 Nov 2016 18:15:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2016 18:15:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id EAEAB1AA9F8 for ; Wed, 23 Nov 2016 18:15:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yu4XTZoySLFW for ; Wed, 23 Nov 2016 18:15:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0AF845F39A for ; Wed, 23 Nov 2016 18:15:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uANIF9QA011819; Wed, 23 Nov 2016 18:15:09 GMT Message-Id: <201611231815.uANIF9QA011819@ip-10-146-233-104.ec2.internal> Date: Wed, 23 Nov 2016 18:15:09 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4518=3A_CopyStringVal=28=29_doesn=27t_copy_null_string=0A?= X-Gerrit-Change-Id: I3a5b9349dd08556eba5cfedc8c0063cc59f5be03 X-Gerrit-ChangeURL: X-Gerrit-Commit: 683daab043af418b78e44d4292719ef968dc9549 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 23 Nov 2016 18:15:18 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-4518: CopyStringVal() doesn't copy null string ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5198/1//COMMIT_MSG Commit Message: PS1, Line 10: emtpy > empty Done http://gerrit.cloudera.org:8080/#/c/5198/1/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: Line 151: *dst = StringVal::null(); > Would be slightly easier to read using an early return here. IMHO, this is fine as it's structured as a series of if-else stmt. -- To view, visit http://gerrit.cloudera.org:8080/5198 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5b9349dd08556eba5cfedc8c0063cc59f5be03 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes