Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D84B6200BC2 for ; Thu, 17 Nov 2016 19:08:22 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D7EB8160B0B; Thu, 17 Nov 2016 18:08:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 32328160AD8 for ; Thu, 17 Nov 2016 19:08:22 +0100 (CET) Received: (qmail 96721 invoked by uid 500); 17 Nov 2016 18:08:21 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 96710 invoked by uid 99); 17 Nov 2016 18:08:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Nov 2016 18:08:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A9E8F180538 for ; Thu, 17 Nov 2016 18:08:20 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id m5Qz42W6qY3v for ; Thu, 17 Nov 2016 18:08:18 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2CBFF5F295 for ; Thu, 17 Nov 2016 18:08:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAHI8CpY016684; Thu, 17 Nov 2016 18:08:12 GMT Message-Id: <201611171808.uAHI8CpY016684@ip-10-146-233-104.ec2.internal> Date: Thu, 17 Nov 2016 18:08:12 +0000 From: "Tim Armstrong (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Add_a_build_flag_for_the_undefined_behavior_sanitizer=2C_aka_=22ubsan=22=2E=0A?= X-Gerrit-Change-Id: I88c7234bd7c5eb7404490a0913d90470c10835e7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 3edb9054d0cd9bdceaa9cd2ee0b715937fc90088 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 17 Nov 2016 18:08:23 -0000 Tim Armstrong has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 40: # -fwrapv: force signed integer arithmetic operations to wrap > This was already assumed, and a number of our tests depend on it holding. My preference is not to add this option and to fix any cases where values are actually wrapping at runtime. This could have performance implications, since a lot of "obvious" loop optimisations can depend on array indices, etc not wrapping. Also we're not enabling this for codegen, which potentially add a gap to our test coverage. -- To view, visit http://gerrit.cloudera.org:8080/5082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88c7234bd7c5eb7404490a0913d90470c10835e7 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes