Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 91C31200BD4 for ; Thu, 17 Nov 2016 00:13:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 90B98160B13; Wed, 16 Nov 2016 23:13:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D552A160B08 for ; Thu, 17 Nov 2016 00:13:05 +0100 (CET) Received: (qmail 86022 invoked by uid 500); 16 Nov 2016 23:13:05 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 86011 invoked by uid 99); 16 Nov 2016 23:13:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Nov 2016 23:13:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 70757180610 for ; Wed, 16 Nov 2016 23:13:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4c2eUdmSWBc2 for ; Wed, 16 Nov 2016 23:13:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C4A745F472 for ; Wed, 16 Nov 2016 23:13:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAGND0WR030323; Wed, 16 Nov 2016 23:13:00 GMT Message-Id: <201611162313.uAGND0WR030323@ip-10-146-233-104.ec2.internal> Date: Wed, 16 Nov 2016 23:13:00 +0000 From: "Alex Behm (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3713=2CIMPALA-4439=3A_Fix_Kudu_DML_shell_reporting=0A?= X-Gerrit-Change-Id: I3d3d7aa8d176e03ea58fb00f2a81fb3e34965aa1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 29bc4b3018cbd75655bbe5195aaafa0ffca724c9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 16 Nov 2016 23:13:06 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5103/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: Line 260: // Number of row operations attempted but not modified due to errors reported by the Suggest some minor rephrasing: Number of row operations attempted but not completed due to non-fatal errors reported by the storage engine that Impala treats as warnings. http://gerrit.cloudera.org:8080/#/c/5103/2/shell/impala_shell.py File shell/impala_shell.py: Line 928: error_report = ", %d row error(s)" % (num_row_errors) Don't we need to check somewhere whether num_row_errors was set in the response thrift struct? This still seems to add the error report for all DML statements, but maybe I'm missing something. -- To view, visit http://gerrit.cloudera.org:8080/5103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3d7aa8d176e03ea58fb00f2a81fb3e34965aa1 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Matthew Jacobs Gerrit-HasComments: Yes