Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BA918200BD0 for ; Wed, 16 Nov 2016 05:57:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B9194160B05; Wed, 16 Nov 2016 04:57:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0D569160B03 for ; Wed, 16 Nov 2016 05:57:04 +0100 (CET) Received: (qmail 62549 invoked by uid 500); 16 Nov 2016 04:57:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 62533 invoked by uid 99); 16 Nov 2016 04:57:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Nov 2016 04:57:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 71C4FC7CD4 for ; Wed, 16 Nov 2016 04:57:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4NKkkNTC14ce for ; Wed, 16 Nov 2016 04:57:01 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 26D205FBCD for ; Wed, 16 Nov 2016 04:57:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAG4utSY014117; Wed, 16 Nov 2016 04:56:55 GMT Message-Id: <201611160456.uAG4utSY014117@ip-10-146-233-104.ec2.internal> Date: Wed, 16 Nov 2016 04:56:55 +0000 From: "Alex Behm (Code Review)" To: Matthew Jacobs , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3713=2CIMPALA-4439=3A_Fix_Kudu_DML_shell_reporting=0A?= X-Gerrit-Change-Id: I3d3d7aa8d176e03ea58fb00f2a81fb3e34965aa1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6f4aa1b9d34aa3c7dbea3b549acce64284b35488 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 16 Nov 2016 04:57:05 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3713,IMPALA-4439: Fix Kudu DML shell reporting ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5103/1/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 532: insert_result->__set_num_row_errors(num_row_errors); Can we leave this unset for DML where reporting the num_row_errors doesn't make sense? Based on the code here, I think we'll report them for all DML (even non-Kudu), right? http://gerrit.cloudera.org:8080/#/c/5103/1/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: Line 260: // Number of rows that weren't modified due to errors. Only applies to Kudu tables. Can you qualify errors more precisely? These are constraint violations correct, and not really Kudu "errors", right? http://gerrit.cloudera.org:8080/#/c/5103/1/shell/impala_shell.py File shell/impala_shell.py: Line 928: errors_stmt = ", %d row error(s)" % (num_row_errors) Let's avoid "stmt" since that is a somewhat overloaded abbreviation (aka SQL statement). error_report? -- To view, visit http://gerrit.cloudera.org:8080/5103 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3d7aa8d176e03ea58fb00f2a81fb3e34965aa1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs Gerrit-Reviewer: Alex Behm Gerrit-HasComments: Yes