Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8CD66200BC0 for ; Tue, 15 Nov 2016 12:03:02 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 884DE160B03; Tue, 15 Nov 2016 11:03:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D20EF160B02 for ; Tue, 15 Nov 2016 12:03:01 +0100 (CET) Received: (qmail 93464 invoked by uid 500); 15 Nov 2016 11:03:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 93453 invoked by uid 99); 15 Nov 2016 11:03:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Nov 2016 11:03:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6FA70C18B0 for ; Tue, 15 Nov 2016 11:03:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id cVK6W5PnDGuc for ; Tue, 15 Nov 2016 11:02:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F2E7A5F472 for ; Tue, 15 Nov 2016 11:02:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAFB2uol026211; Tue, 15 Nov 2016 11:02:56 GMT Message-Id: <201611151102.uAFB2uol026211@ip-10-146-233-104.ec2.internal> Date: Tue, 15 Nov 2016 11:02:56 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm , Taras Bobrovytsky Reply-To: jbapple@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4434=3A_In_Python=2C_=27=27=2Esplit=28=27=5Cn=27=29_is_=5B=27=27=5D=2C_which_has_length_1=0A?= X-Gerrit-Change-Id: Iac4943085b0693deb380499cd0e141eb672bead8 X-Gerrit-ChangeURL: X-Gerrit-Commit: cdf903919620ef7ca3bd0d4bc6836d661ce89827 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 15 Nov 2016 11:03:02 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4434: In Python, ''.split('\n') is [''], which has length 1 ...................................................................... Patch Set 2: Code-Review+2 rebase only; carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac4943085b0693deb380499cd0e141eb672bead8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: No