Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF438200BC9 for ; Sat, 12 Nov 2016 06:12:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DDD68160B14; Sat, 12 Nov 2016 05:12:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 31C6E160AF6 for ; Sat, 12 Nov 2016 06:12:08 +0100 (CET) Received: (qmail 67665 invoked by uid 500); 12 Nov 2016 05:12:06 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 67654 invoked by uid 99); 12 Nov 2016 05:12:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Nov 2016 05:12:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 35339C7D57 for ; Sat, 12 Nov 2016 05:12:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id bTfdzRUXA6zc for ; Sat, 12 Nov 2016 05:12:04 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4C9235F3BA for ; Sat, 12 Nov 2016 05:12:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAC591A0013646; Sat, 12 Nov 2016 05:09:01 GMT Message-Id: <201611120509.uAC591A0013646@ip-10-146-233-104.ec2.internal> Date: Sat, 12 Nov 2016 05:09:01 +0000 From: "Alex Behm (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4444=3A_Transfer_row_group_resources_to_row_batch_on_scan_failure=0A?= X-Gerrit-Change-Id: Id70df470e98dd96284fd176bfbb946e9637ad126 X-Gerrit-ChangeURL: X-Gerrit-Commit: 84e1f2624e0acb9444aab2ee5670c1e2c5b18d8f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Sat, 12 Nov 2016 05:12:09 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-4444: Transfer row group resources to row batch on scan failure ...................................................................... Patch Set 1: I don't think we need to trigger the bug with exactly the same query. If we find a test that repros the issue frequently enough on ASAN I think we're ok. Sounds like it could be sufficient to just have a scan plus an exchange, or some other simpler variant. -- To view, visit http://gerrit.cloudera.org:8080/5052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id70df470e98dd96284fd176bfbb946e9637ad126 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Ho Gerrit-HasComments: No