Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 199E4200BBB for ; Thu, 10 Nov 2016 20:48:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 18649160B01; Thu, 10 Nov 2016 19:48:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F121160AF7 for ; Thu, 10 Nov 2016 20:48:56 +0100 (CET) Received: (qmail 35069 invoked by uid 500); 10 Nov 2016 19:48:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 35058 invoked by uid 99); 10 Nov 2016 19:48:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 19:48:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E355A1A7F37 for ; Thu, 10 Nov 2016 19:48:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lf2rYLz2Cz5I for ; Thu, 10 Nov 2016 19:48:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D09D25F65A for ; Thu, 10 Nov 2016 19:48:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uAAJmn5s021354; Thu, 10 Nov 2016 19:48:49 GMT Message-Id: <201611101948.uAAJmn5s021354@ip-10-146-233-104.ec2.internal> Date: Thu, 10 Nov 2016 19:48:49 +0000 From: "Henry Robinson (Code Review)" To: Yonghyun Hwang , Bharath Vissapragada , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Huaisi Xu , Alex Behm , Dan Hecht Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3552=3A_Make_incremental_stats_max_serialized_size_configurable=0A?= X-Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 X-Gerrit-ChangeURL: X-Gerrit-Commit: b0f04d0d37c3035277e50ed8e552142bef44ea5e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 10 Nov 2016 19:48:57 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/4867/10/common/thrift/BackendGflags.thrift File common/thrift/BackendGflags.thrift: PS10, Line 22: Attributes without comments correspond to gflags If these aren't 1:1 with gflags, let's call the struct TBackendFlags. -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 10 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Huaisi Xu Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: Yes