Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C52A6200BC5 for ; Tue, 8 Nov 2016 07:05:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C3B90160AF9; Tue, 8 Nov 2016 06:05:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15866160AEC for ; Tue, 8 Nov 2016 07:05:09 +0100 (CET) Received: (qmail 77955 invoked by uid 500); 8 Nov 2016 06:05:09 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 77937 invoked by uid 99); 8 Nov 2016 06:05:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Nov 2016 06:05:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C76AEC9B11 for ; Tue, 8 Nov 2016 06:05:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tsDfRqBMAPJr for ; Tue, 8 Nov 2016 06:05:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8BDA05FBDC for ; Tue, 8 Nov 2016 06:05:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uA864w1h007709; Tue, 8 Nov 2016 06:04:58 GMT Message-Id: <201611080604.uA864w1h007709@ip-10-146-233-104.ec2.internal> Date: Tue, 8 Nov 2016 06:04:58 +0000 From: "Alex Behm (Code Review)" To: Yonghyun Hwang , Bharath Vissapragada , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Huaisi Xu Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3552=3A_Make_incremental_stats_max_serialized_size_configurable=0A?= X-Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8b966a50c6711db74b391d573bfe90b373590b7a In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 08 Nov 2016 06:05:11 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-3552: Make incremental stats max serialized size configurable ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.cc File be/src/catalog/catalog.cc: Line 151: Status Catalog::GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) const { Can we refactor the code to only have one GetBackendConfigBytes() or are there any differences between this one and the one used for the FE? http://gerrit.cloudera.org:8080/#/c/4867/7/be/src/catalog/catalog.h File be/src/catalog/catalog.h: Line 106: Status GetCatalogConfigBytes(JNIEnv* jni_env, jbyteArray* cfg_bytes) const; GetBackendConfigBytes()? http://gerrit.cloudera.org:8080/#/c/4867/5/common/thrift/Types.thrift File common/thrift/Types.thrift: Line 249: 6: optional bool compute_lineage > Isn't it better if we let the backend drive the decision here and just pass Let's continue down this path for now and see how it goes. -- To view, visit http://gerrit.cloudera.org:8080/4867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33684725a61eabc67237503e61178305d37d3cb5 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Yonghyun Hwang Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Huaisi Xu Gerrit-Reviewer: Yonghyun Hwang Gerrit-Reviewer: Yonghyun Hwang Gerrit-HasComments: Yes