Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5136E200BC4 for ; Sat, 5 Nov 2016 01:06:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4FBDC160B04; Sat, 5 Nov 2016 00:06:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 979B3160AFE for ; Sat, 5 Nov 2016 01:06:54 +0100 (CET) Received: (qmail 29901 invoked by uid 500); 5 Nov 2016 00:06:53 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 29886 invoked by uid 99); 5 Nov 2016 00:06:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Nov 2016 00:06:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1E3A1C1444 for ; Sat, 5 Nov 2016 00:06:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 3omDXXZ_FK0g for ; Sat, 5 Nov 2016 00:06:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 010345F576 for ; Sat, 5 Nov 2016 00:06:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uA5063UN016753; Sat, 5 Nov 2016 00:06:03 GMT Message-Id: <201611050006.uA5063UN016753@ip-10-146-233-104.ec2.internal> Date: Sat, 5 Nov 2016 00:06:02 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , David Knupp Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D=28asf-site=29_Add_=22Effective_Coding_Practices=22_doc_to_site=0A?= X-Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263 X-Gerrit-ChangeURL: X-Gerrit-Commit: 20692feac627a68aadfa18e672d350af96e2b7a1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Sat, 05 Nov 2016 00:06:55 -0000 Tim Armstrong has posted comments on this change. Change subject: Add "Effective Coding Practices" doc to site ...................................................................... Patch Set 2: I can see it being a blog post. Mainly I didn't think it fit on the wiki since it should be a static document. How would you feel about that, Henry? -- To view, visit http://gerrit.cloudera.org:8080/4961 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21fdce898a71be836b658e0c914e05a6868d6263 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: asf-site Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No