Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201611042327.uA4NRu9E014980@ip-10-146-233-104.ec2.internal>
Date: Fri, 4 Nov 2016 23:27:56 +0000
From: "Marcel Kornacker (Code Review)" <gerrit@cloudera.org>
To: Laszlo Gaal <laszlo.gaal@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: marcel@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4172=3A_Switch_to_BlockLocation_methods_for_disk_IDs=0A?=
In-Reply-To: <gerrit.1478111171000.Ibbff94cef9a9db7b3945f8e7b0286866d2cc3b61@gerrit.cloudera.org>
References: <gerrit.1478111171000.Ibbff94cef9a9db7b3945f8e7b0286866d2cc3b61@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Fri, 04 Nov 2016 23:28:05 -0000

Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4172: Switch to BlockLocation methods for disk IDs
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4914/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

Line 379:   private static int getDiskId(String storageId) {
> In the BE we mod the disk id to determine which disk queue to put reads on,
it's very unusual for a server to have more than 128 disks (i don't think we've ever seen one), so from that perspective i'm not worried about using fewer bits to represent the disk "ordinal".

keep in mind that we really don't care about distinguishing disks globally. using a designated "out of range" value (such as 127) if a node should really exceed 127 disks, and then placing scan ranges with that value on random disk queues should degrade performance gracefully in cases where the number of disks is just a bit above that threshold.


-- 
To view, visit http://gerrit.cloudera.org:8080/4914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbff94cef9a9db7b3945f8e7b0286866d2cc3b61
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <laszlo.gaal@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes