Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C2E85200BB3 for ; Wed, 2 Nov 2016 16:30:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C1988160AFB; Wed, 2 Nov 2016 15:30:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 11BC2160AF0 for ; Wed, 2 Nov 2016 16:30:08 +0100 (CET) Received: (qmail 76114 invoked by uid 500); 2 Nov 2016 15:30:08 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 76103 invoked by uid 99); 2 Nov 2016 15:30:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2016 15:30:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8F9F11A0544 for ; Wed, 2 Nov 2016 15:30:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id r18f63ThGk7O for ; Wed, 2 Nov 2016 15:30:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D90715FC74 for ; Wed, 2 Nov 2016 15:30:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id uA2FTv9V000530; Wed, 2 Nov 2016 15:29:57 GMT Message-Id: <201611021529.uA2FTv9V000530@ip-10-146-233-104.ec2.internal> Date: Wed, 2 Nov 2016 15:29:57 +0000 From: "Michael Brown (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Matthew Jacobs , Dimitris Tsirogiannis , Taras Bobrovytsky , Harrison Sheinblatt , David Knupp Reply-To: mikeb@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4352=3A_test_infra=3A_store_Impala/Kudu_primary_keys_in_object_model=0A?= X-Gerrit-Change-Id: Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5 X-Gerrit-ChangeURL: X-Gerrit-Commit: 096317011380db43d71a55ca6c87cc2cc24827db In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 02 Nov 2016 15:30:09 -0000 Michael Brown has posted comments on this change. Change subject: IMPALA-4352: test infra: store Impala/Kudu primary keys in object model ...................................................................... Patch Set 2: (1 comment) Thanks for the comment, Taras. Please set patch set 2. http://gerrit.cloudera.org:8080/#/c/4873/1/tests/comparison/db_connection.py File tests/comparison/db_connection.py: Line 407: table.add_col(col) > col.is_primary_key = col_name in primary_key_names Done -- To view, visit http://gerrit.cloudera.org:8080/4873 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib654b6cd0e8c2a172ffb7330497be4d4a751e6e5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Harrison Sheinblatt Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: Yes