Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201611020104.uA214W8i025510@ip-10-146-233-104.ec2.internal>
Date: Wed, 2 Nov 2016 01:04:32 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: Henry Robinson <henry@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Sailesh Mukil <sailesh@cloudera.com>
Reply-To: tarmstrong@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4410=3A_Safer_tear-down_of_RuntimeState=0A?=
In-Reply-To: <gerrit.1477952711000.Ie416e4d57240142bf685385299b749c3a6792c45@gerrit.cloudera.org>
References: <gerrit.1477952711000.Ie416e4d57240142bf685385299b749c3a6792c45@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 02 Nov 2016 01:04:56 -0000

Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4410: Safer tear-down of RuntimeState
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4893/1/be/src/runtime/runtime-state.cc
File be/src/runtime/runtime-state.cc:

PS1, Line 300: RuntimeState::Close()
> Fair point. I'm going to leave TestEnv for now - looking into that code it'
The ownership is actually really simple - TestEnv owns the RuntimeStates and destroys them in TestEnv::TearDownQueryStates(). So you could just close them in that function.

Maybe the red herring is that TestEnv::query_states_ uses shared_ptr. It could actually be switched to unique_ptr - the ownership is actually exclusive, the code was just written before C++11 support.


-- 
To view, visit http://gerrit.cloudera.org:8080/4893
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie416e4d57240142bf685385299b749c3a6792c45
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes