Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201611010040.uA10ehsL002917@ip-10-146-233-104.ec2.internal>
Date: Tue, 1 Nov 2016 00:40:43 +0000
From: "Sailesh Mukil (Code Review)" <gerrit@cloudera.org>
To: Matthew Jacobs <mj@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: sailesh@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4411=3A_Kudu_inserts_violate_lock_ordering_and_could_deadlock=0A?=
In-Reply-To: <gerrit.1477958438000.I2aa36fce78525a80a6b880e1b668105006bc1425@gerrit.cloudera.org>
References: <gerrit.1477958438000.I2aa36fce78525a80a6b880e1b668105006bc1425@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Tue, 01 Nov 2016 00:40:50 -0000

Sailesh Mukil has posted comments on this change.

Change subject: IMPALA-4411: Kudu inserts violate lock ordering and could deadlock
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4895/1/be/src/service/query-exec-state.cc
File be/src/service/query-exec-state.cc:

PS1, Line 537: session_->kudu_latest_observed_ts = std::max<uint64_t>(
             :           session_->kudu_latest_observed_ts, latest_kudu_ts);
> It's a good idea, though I don't think this lock is particularly highly con
I just grepped through the codebase and one call in particular seems to be made in many places. "WithSession()". That function gets the session_ lock.

But if it seems like an over-optimization for now, I'm fine with leaving it as it is.


-- 
To view, visit http://gerrit.cloudera.org:8080/4895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2aa36fce78525a80a6b880e1b668105006bc1425
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes