impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix undefined cals to builtin ctz.
Date Wed, 30 Nov 2016 19:51:45 GMT
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5278

Change subject: Fix undefined cals to __builtin_ctz.
......................................................................

Fix undefined cals to __builtin_ctz.

GCC's __builtin_ctz[l[l]] functions return undefined results when the
argument is 0. This patch handles that 0 case, which could otherwise
produce results that depend on the architecture.

Change-Id: Id569c48824d1c4575d6bfde106df0eb80ab9623c
---
M be/src/exprs/aggregate-functions-ir.cc
M be/src/udf_samples/hyperloglog-uda.cc
M be/src/util/bit-util.h
3 files changed, 43 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/5278/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id569c48824d1c4575d6bfde106df0eb80ab9623c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>

Mime
View raw message