impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots
Date Tue, 29 Nov 2016 23:03:56 GMT
Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5265

Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
......................................................................

IMPALA-4550: Fix CastExpr analysis for substituted slots

During slot substitution, the type of the child of a CastExpr can
change. If the previous child type matched the CastExpr, then the cast
was flagged as noOp_. During substitution and subsequent re-analysis
the noOp_ flag was not revisited so that no cast was performed, even
after it had become necessary.

The fix is to set the noOp_ flag to the correct value in all cases.

Change-Id: Id8841fe7fd9106041e9b68970adf265d2aa22be2
---
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
2 files changed, 16 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/5265/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8841fe7fd9106041e9b68970adf265d2aa22be2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>

Mime
View raw message