impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly
Date Tue, 29 Nov 2016 19:34:29 GMT
Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5260

Change subject: Fix E2E test infrastructure to handle missing exceptions correctly
......................................................................

Fix E2E test infrastructure to handle missing exceptions correctly

This change fixes a bug in the E2E infrastructure that handles
the case when an expected exception wasn't thrown. The code was
expecting that test_section['CATCH'] to be a string but in
reality it's a list of strings. It also clarifies the error
message about the missing exception. This change also enforces
that the CATCH subsection in tests cannot be empty.

Change-Id: I7d83c5db59e8a239e4e70694a1e625af6f21419c
---
M tests/common/impala_test_suite.py
M tests/util/test_file_parser.py
2 files changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/5260/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d83c5db59e8a239e4e70694a1e625af6f21419c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
View raw message