impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4540: Function call in DCHECK crashes scheduler
Date Thu, 24 Nov 2016 21:04:17 GMT
Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5217

Change subject: IMPALA-4540: Function call in DCHECK crashes scheduler
......................................................................

IMPALA-4540: Function call in DCHECK crashes scheduler

The fix for IMPALA-4494 wrapped the call to
backend_config_.LookUpBackendIp in simple-scheduler.cc:922 in a DCHECK,
effectively disabling it in release builds. This leads to a crash when
backend_ip is empty.

This change makes sure that the function is always called.

Change-Id: I12b7f5cc54e00ef5136ef0078c210c830ba78fb7
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/5217/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5217
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I12b7f5cc54e00ef5136ef0078c210c830ba78fb7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>

Mime
View raw message