impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4525: fix crash when codegen mem limit exceeded
Date Wed, 23 Nov 2016 21:53:38 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5211

Change subject: IMPALA-4525: fix crash when codegen mem limit exceeded
......................................................................

IMPALA-4525: fix crash when codegen mem limit exceeded

The error path in OptimizeLlvmModule() has not worked correctly for a
long time because various places in the code assume that codegen'd
function pointers will be filled in (e.g. ScalarFnCall) . Since the
recent change "IMPALA-4397,IMPALA-3259: reduce codegen time and memory"
it is more likely to go down this path.

The cases when errors occur on this path: memory limit exceeded, internal
codegen bugs, and corrupt IR UDFs, are all cases when it is not correct
or safe to continue executing the query, so we should just fail the
query.

Testing:
Add a test where codegen reliably fails with memory limit exceeded.

Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505
---
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/plan-fragment-executor.h
A testdata/workloads/functional-query/queries/QueryTest/codegen-mem-limit.test
M tests/query_test/test_query_mem_limit.py
4 files changed, 32 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/11/5211/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5211
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib38d0a44b54c47617cad1b971244f477d344d505
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message