impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner
Date Thu, 17 Nov 2016 00:19:42 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5115

Change subject: IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner
......................................................................

IMPALA-2494: Support for byte array-encoded decimals in Parquet scanner

* Extend metadata checks to allow more than one possible physical type
  for a given logical type.
* Change decimal decoding to handle non-fixed-length format in same path
  as fixed-length encoding.

Testing:

 * Query test that decodes dictionary-encoded decimals using binary
   encoding.

Perf:

 * Tested computing SUM(col) for 1 billion distinct dictionary-encoded
   decimal(12,2) values using FIXED_BYTE_ARRAY physical type encoding.
 * No performance difference measured by introduction of extra
   predictable branch to Decode() path.

Change-Id: If95171e65aa48f08b08b8e87f4555dc75e867977
---
M be/src/exec/parquet-column-readers.cc
M be/src/exec/parquet-common.h
M be/src/exec/parquet-metadata-utils.cc
M testdata/bin/create-load-data.sh
A testdata/data/byte_array_decimal_dict_encoded.parquet
A testdata/workloads/functional-query/queries/QueryTest/decimal-encodings.test
M tests/query_test/test_scanners.py
7 files changed, 118 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/5115/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5115
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If95171e65aa48f08b08b8e87f4555dc75e867977
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message