impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4435: Fix in-predicate-benchmark linking by moving templates
Date Sat, 05 Nov 2016 14:14:16 GMT
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4966

Change subject: IMPALA-4435: Fix in-predicate-benchmark linking by moving templates
......................................................................

IMPALA-4435: Fix in-predicate-benchmark linking by moving templates

In C++ (without export, which was removed in C++11), templates
definitions (and not just declarations) must be in headers in order to
be implicitly instantiated by callers. in-predicate-benchmark was
http://gerrit.cloudera.org:8080/4758; this patch fixes the linker
errors that were caused in some build modes by #including only the
template declarations.

Change-Id: Ie95ec71242b97f28c68e37d6f44956f2eeff8105
---
M be/src/exprs/in-predicate-ir.cc
M be/src/exprs/in-predicate.h
2 files changed, 114 insertions(+), 113 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/4966/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie95ec71242b97f28c68e37d6f44956f2eeff8105
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>

Mime
View raw message