impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4435: Fix in-predicate-benchmark link error in release mode
Date Sat, 05 Nov 2016 05:12:49 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4964

Change subject: IMPALA-4435: Fix in-predicate-benchmark link error in release mode
......................................................................

IMPALA-4435: Fix in-predicate-benchmark link error in release mode

in-predicate-benchmark would not link in release mode only after a
recent change fixed an include to target a .h file rather that an *ir.cc
file. Unfortunately, this also prevented the required symbols from being
visible to the linker.

There might be a more principled approach than reverting the change and
asking clang-tidy to ignore it, but since the benchmarks are not
production code and are rarely run, simple seems best.

Change-Id: I7e0091b25e4d10780f963b74734e0ee81b7f1c39
---
M be/src/benchmarks/in-predicate-benchmark.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/4964/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e0091b25e4d10780f963b74734e0ee81b7f1c39
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message