impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] Improve Kudu UPSERT test coverage
Date Mon, 07 Nov 2016 23:00:58 GMT
Thomas Tauber-Marshall has uploaded a new change for review.

Change subject: Improve Kudu UPSERT test coverage

Improve Kudu UPSERT test coverage

In preparation for the public lease of Kudu integration in
5.10, we need to make sure that we've covered as much of the
Kudu related functionality with tests as possible. This patch
covers UPSERT.

It also introduces a new test section 'DML_RESULTS', which
takes the name of a table as a comment and the contents of the
table as its body and then verifies that the body matches the
actual contents of the table. This makes it easy to check that a
DML operation has the desired effect on the contents of a table,
rather than always having to add another test case that runs a
select on the table.

Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6
M testdata/workloads/functional-query/queries/QueryTest/kudu_crud.test
A testdata/workloads/functional-query/queries/QueryTest/kudu_upsert.test
M tests/common/
M tests/common/
M tests/query_test/
M tests/util/
6 files changed, 496 insertions(+), 66 deletions(-)

  git pull ssh:// refs/changes/53/4953/2
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9e7afbef60186edb00a9d11fbe5a8c64931add6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>

View raw message