impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4412: Per operator timing in profile summary is incorrect when mt dop > 0
Date Thu, 03 Nov 2016 17:59:17 GMT
Sailesh Mukil has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4933

Change subject: IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop
> 0
......................................................................

IMPALA-4412: Per operator timing in profile summary is incorrect when mt_dop > 0

With mt_dop > 0, we may incorrectly populate the
per_fragment_instance_idx for each FInstanceExecParams in
SimpleScheduler::CreateScanInstances().

This causes the averages in the exec summary to be wrong resulting in
misleading Runtime Profiles.

This patch makes sure that each FInstanceExecParams has the correct
instance index associated with it, thereby fixing the exec summaries
in the runtime profiles.

Change-Id: Id8634acba05698281e698ab8ddf92db4ae38af88
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/4933/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4933
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8634acba05698281e698ab8ddf92db4ae38af88
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message