impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality().
Date Thu, 03 Nov 2016 04:47:08 GMT
Alex Behm has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4925

Change subject: IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality().
......................................................................

IMPALA-4174: Refine PK/FK detection in JoinNode.getJoinCardinality().

Changes the PK/FK detection logic to require that the RHS is probably
a primary key. Previously the RHS PK condition was optional if the
LHS was estimated to probably be a FK.
Also doubles the allowed slop for the PK/FK detection logic.

The main motivation of this change is to more accurately detect and
cost M:N joins which had lead to pathologically bad join orders.

Performance:
Improves TPC-DS Q10 and Q72 by >8x
Improves several TPC-H queries by a few 10s of percent.
Otherwise, there are no significant changes to TPC-H and TPC-DS.

Speedup:  Avg  / Geomean
TPC-DS   1.3x  /    1.1x
TPC-H    1.0x  /    1.1x

Change-Id: Ibe652366352964db96c2f772905ec53fdb9954dd
---
M fe/src/main/java/org/apache/impala/planner/JoinNode.java
M testdata/workloads/functional-planner/queries/PlannerTest/hbase.test
M testdata/workloads/functional-planner/queries/PlannerTest/join-order.test
M testdata/workloads/functional-planner/queries/PlannerTest/joins.test
M testdata/workloads/functional-planner/queries/PlannerTest/nested-collections.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-all.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpch-views.test
9 files changed, 781 insertions(+), 778 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/4925/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4925
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe652366352964db96c2f772905ec53fdb9954dd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>

Mime
View raw message