impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir
Date Wed, 02 Nov 2016 19:47:14 GMT
David Knupp has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4918

Change subject: IMPALA-4421: Write custom cluster and process failure test results to Impala
logs dir
......................................................................

IMPALA-4421: Write custom cluster and process failure test results to Impala logs dir

Improperly nested quotes in tests/run-custom-cluster-tests.sh caused a
directory named "${RESULTS_DIR}" to be created in the tests directory,
which in turned interfered with run-tests.py.

Additonally noticed that run-process-failure-tests.sh was creating a
results directory within tests/. We shoud not be polluting the tests/ dir
with random test artifacts, so changed the result directory path for
those tests as well.

Tested by running both scripts, and ensuring that results wound up in
logs/, and nothing was created in tests/.

Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd
---
M tests/run-custom-cluster-tests.sh
M tests/run-process-failure-tests.sh
2 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/4918/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I475f61b4ba8a693324bbefed8819d029674b66dd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>

Mime
View raw message