impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4410: Safer tear-down of RuntimeState
Date Wed, 02 Nov 2016 00:23:58 GMT
Henry Robinson has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4910

Change subject: IMPALA-4410: Safer tear-down of RuntimeState
......................................................................

IMPALA-4410: Safer tear-down of RuntimeState

* Add RuntimeState::Close() which is guaranteed to release resources
  safely, rather than having PFE::Close() do the same piecemeal.
* Fix for crash where PFE::Prepare() fails before descriptor table is
  created.

Change-Id: I5f8244f41b247a82464f1e102a3b82e2001ccc1e
Testing: Found by debug-actions, which has a reproducible test where
PFE::Prepare() fails. Manually tested on master.
---
M be/src/runtime/plan-fragment-executor.cc
M be/src/runtime/runtime-state.cc
M be/src/runtime/runtime-state.h
M be/src/service/fe-support.cc
A be/src/util/scope-exit-trigger.h
5 files changed, 61 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/4910/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f8244f41b247a82464f1e102a3b82e2001ccc1e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>

Mime
View raw message