impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"
Date Wed, 30 Nov 2016 23:52:36 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-4527: Columns in Kudu tables created from Impala default to "NULL"
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5259/1/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java:

Line 104:       if (column.isSetIs_nullable()) {
> This won't handle the ALTER TABLE ADD COLUMN case. Let's think about whethe
There is no such place to handle both these cases. The fact that primary keys can be defined
in both the column definitions and as a separate list of column names complicates things,
i.e. we can't be setting the nullability while analyzing the ColumnDef. Changed the code to
handle the addColumn as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/5259
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I950d9a9c64e3851e11a641573617790b340ece94
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message