impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4557: Fix flakiness with FLAGS stress free pool alloc
Date Wed, 30 Nov 2016 23:34:06 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-4557: Fix flakiness with FLAGS_stress_free_pool_alloc
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5281/1/be/src/runtime/free-pool.h
File be/src/runtime/free-pool.h:

Line 214:   static AtomicInt32 alloc_counts_;
> https://github.com/apache/incubator-impala/blob/master/be/src/common/atomic
I think it's clearer to explicitly initialize the value.

While you're doing this, I think it's also best to turn the DCHECK in atomic.h into a static_assert
to make it impossible for there to be a Static Initialization Order Fiasco bug with DCHECK's
logging facilities:

https://isocpp.org/wiki/faq/ctors#static-init-order


-- 
To view, visit http://gerrit.cloudera.org:8080/5281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I373035d209a0f3477650336ee6da458fa289dbe0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message