impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales
Date Wed, 30 Nov 2016 18:33:43 GMT
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5177

to look at the new patch set (#4).

Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales
......................................................................

IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales

This patch changes the way we load tpcds.store_sales test data. Before
this, we were relying on a force_reload to build the table partitions
based upon the data that had been copied over to HDFS from the warehouse
snapshot. This worked on the local mini-cluster, but for some reason,
it was selectively duplicating data when run on a remote cluster.

This patch doesn't solve the mystery of why data duplication occurs on
remote clusters, but it does resolve the immediate concern of loading
test data by using Impala's recover partitions feature to automatically
recognize the partitions in the HDFS directories. We just needed to add
an ALTER TABLE store_sales RECOVER PARTITIONS to the tpcds schema
template file.

Tested by dropping the tpcds table on from a remote cluster setup,
reloading the table, and running the tests in test_tpcds_queries.py.
Tests that had been failng before are now passing.

Change-Id: Iaae97d1d44201aeeacacdd39adbae35753512950
---
M testdata/datasets/tpcds/tpcds_schema_template.sql
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/5177/4
-- 
To view, visit http://gerrit.cloudera.org:8080/5177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaae97d1d44201aeeacacdd39adbae35753512950
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Harrison Sheinblatt <hs7@hotmail.com>

Mime
View raw message