impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model
Date Wed, 30 Nov 2016 00:36:29 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4343,IMPALA-4354: qgen: model INSERTs; write INSERTs from query model

Patch Set 5:

File tests/comparison/

Line 105:   def _write_query(self, query):
Where does _write_query get used?

PS5, Line 430: is not
How about changing the order of if and else to get rid of the not:
if insert_clause.column_permutations is None:
File tests/comparison/

PS5, Line 35: self.parent
It's a good idea to add a comment explaining what each variable means.

Line 40:   def table_exprs(self):
I think it's kind of strange to have both @abstractproperty and the implementation. Is this
a common pattern?

Line 50:     return table_exprs
return self.with_clause.table_exprs if self.with_clause else []

PS5, Line 61: Query
I think the word query is not the best choice any more. Let's call this SelectStatement?

Line 84: 
why a blank line?

PS5, Line 661: column_permutations is an optional sequence of Column objects
Can you explain in more detail what this is? (e.g. is it a list? what are the element types?)

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e24da78c49e908449b35f0a6276ebe4236ddba
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message