impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4550: Fix CastExpr analysis for substituted slots
Date Tue, 29 Nov 2016 23:42:51 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4550: Fix CastExpr analysis for substituted slots
......................................................................


Patch Set 1: Code-Review+2

(5 comments)

Nice!

http://gerrit.cloudera.org:8080/#/c/5267/1//COMMIT_MSG
Commit Message:

Line 15: The fix is to set the noOp_ flag to the correct value in all cases.
The fix is to always set noOp_ to the correct value in CastExpr.analyze().


http://gerrit.cloudera.org:8080/#/c/5267/1/testdata/workloads/functional-query/queries/QueryTest/exprs.test
File testdata/workloads/functional-query/queries/QueryTest/exprs.test:

Line 2568: # explicit cast.
a no-op explicit cast.


Line 2569: SELECT a.id
Add /* + straight_join */ to make sure the join order is fixed. A change in join order would
make us lose coverage.


Line 2570: FROM   functional.alltypes a
use alltypestiny, no need to do this "large" join


Line 2572: WHERE  (Cast(a.string_col as String) > 'a');
nit: use consistent casing for SQL keywords (everything lowercase like in the rest of this
file)


-- 
To view, visit http://gerrit.cloudera.org:8080/5267
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f29cdc359558fad6df455b8eec0e0eaed00e996
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message