impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix E2E test infrastructure to handle missing exceptions correctly
Date Tue, 29 Nov 2016 19:53:46 GMT
Tim Armstrong has posted comments on this change.

Change subject: Fix E2E test infrastructure to handle missing exceptions correctly
......................................................................


Patch Set 1:

(1 comment)

Did you do an exhaustive test run? Just to be sure that this doesn't break any tests.

http://gerrit.cloudera.org:8080/#/c/5260/1/tests/util/test_file_parser.py
File tests/util/test_file_parser.py:

Line 229:           assert len(exception_str.strip()) != 0, "Empty exception string."
Nit: to be consistent with how we check for empty strings above, we can just use: 

assert exception_str.strip(), "Empty exception string"


-- 
To view, visit http://gerrit.cloudera.org:8080/5260
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d83c5db59e8a239e4e70694a1e625af6f21419c
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message