impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
Date Tue, 29 Nov 2016 16:52:36 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-4172/IMPALA-3653: Improvements to block metadata loading
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5148/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

Line 351:       Map<String, Map<String, FileDescriptor>> newFileDescMap = Maps.newHashMap();
> Before, we used to want to reuse as much of the existing block metadata as 
Done


Line 386:             String[] blockHostPorts = loc.getNames();
> The code and comments around these is very sparse on content, so I think we
Did an initial round of cleanup. Removed all the Preconditions as they seem impossible. Also
this code is on a hot path, so might help save some CPU.


Line 934:     boolean isMarkedCached = isMarkedCached_;
> Looks like we used to force reloading the block locations of cached partiti
Done. It doesn't depend on isMarkCached anymore. This particular line is deadcode. We actually
set partition caching properties in HdfsPartition c'tor by parsing msPartition object. This
was required earlier because updatePartitionFds needed it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5148
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie127658172e6e70dae441374530674a4ac9d5d26
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message