impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Avoid std::function when possible.
Date Mon, 28 Nov 2016 21:49:16 GMT
Jim Apple has posted comments on this change.

Change subject: Avoid std::function when possible.
......................................................................


Patch Set 1:

> Am I right to summarise that your main objection is that
 > std::function() heap allocates?

It's the added hidden run-time complexity generally, which is evidenced by, but not isolated
to, the heap allocation under the hood.

 > I see that there are other reasons to prefer auto in certain
 > situations (e.g. performance), but those mostly seemed like
 > case-specific concerns rather than something we should make
 > general.

I agree.

-- 
To view, visit http://gerrit.cloudera.org:8080/5230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9dc034c2e094ea7f87f78d8d9101a71d8d2e295
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: No

Mime
View raw message