impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow
Date Mon, 28 Nov 2016 12:43:47 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk  overflow
......................................................................


Patch Set 11:

> I have tested that set max_audit_event_log_files to 1. That worked
 > as expected.
 > 
 > I have researched CheckAndRotateLogFiles and associated glog codes.
 > Each severity of the log creates a soft link file always point to
 > the latest log file with the severity. The log switch process
 > includes creating a new log file, delete the old link file, create
 > new link file, so involved in the old and new log files. I think
 > that restrict the minimum log file number greater than 1(>=2) is to
 > ensure  the link files to switch correctly while deleting old log
 > files.

Yes, that makes sense to me. I think in this case we should keep the <= 1 check, to prevent
this race condition.

-- 
To view, visit http://gerrit.cloudera.org:8080/4971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Donghui Xu <davyxdh@163.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message